calcite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Edmon Begoli <ebeg...@gmail.com>
Subject Re: Review and merge
Date Tue, 20 Feb 2018 02:31:26 GMT
Thanks. Will do, too.

I wanted to have this reviewed, and proceed carefully, but going forward I
will operate more autonomously.

On Mon, Feb 19, 2018 at 9:29 PM, Michael Mior <mmior@uwaterloo.ca> wrote:

> Will do. Note that in general PRs should consist of a single commit (you
> can squash commits as needed). Also, while I certainly don't mind deploying
> this, now that you're a committer, you are free to push changes yourself. A
> JIRA should still be created for any non-trivial changes and you're always
> welcome to ask for review. But if you ever have a well-tested (or
> documentation-only change) that is unlikely to be objected, you're always
> welcome to push code yourself :)
>
> --
> Michael Mior
> mmior@apache.org
>
> 2018-02-19 21:16 GMT-05:00 Edmon Begoli <ebegoli@gmail.com>:
>
> > I have an open pull request that can be safely merged, and deployed upon
> > review.
> > It is a web site update:
> > https://github.com/apache/calcite/pull/627
> >
> > Could someone please review and merge.
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message