calcite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stamatis Zampetakis <zabe...@gmail.com>
Subject Review and update pull requests
Date Fri, 10 Aug 2018 08:36:50 GMT
Hi,

Contributing to Calcite is quite well documented in the website (
https://calcite.apache.org/develop/#contributing). One minor thing that
might be missing is how to update the pull request when changes are
required by the reviewers.

Personally, I always perform rebase followed by a forced push in an attempt
to always keep the PR with one commit. However, this may make the changes
more difficult to review.

   1. Is there a preferred way to handle updates in PRs?
   2. Should we update the site with a few extra lines documenting this
   case?

Best,
Stamatis

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message