> Do you feel comfortable with Kafka adapter being part of calcite main codebase ?
+1
I don’t think we need a formal vote. There seems to be consensus that we want this. We need
to get it through the code review process, and I’m sure we can. Andrei has already done
a great job reviewing line-by-line.
I have made high-level comments in https://issues.apache.org/jira/browse/CALCITE-2913 <https://issues.apache.org/jira/browse/CALCITE-2913>.
JIRA is better than GitHub for high-level review (questions such as “How is a release manager
going to test this before each release?”)
Julian
> On May 14, 2019, at 11:56 AM, Andrei Sereda <andrei@sereda.cc> wrote:
>
> Hello,
>
> I have reviewed the PR and it mostly looks good. There are some small
> things left, but no blockers.
>
> Do you feel comfortable with Kafka adapter being part of calcite main
> codebase ? Is there anybody against merging proposed PR ?
>
> Regards.
>
> On Thu, May 9, 2019 at 2:36 PM Mingmin Xu <mingmxus@gmail.com> wrote:
>
>> Thank you Andrei, appreciated for your time.
>>
>> On Thu, May 9, 2019 at 11:29 AM Andrei Sereda <andrei@sereda.cc> wrote:
>>
>>> Mingmin, I'll be reviewing the PR this week.
>>> Sorry was busy last couple of weeks.
>>>
>>> On Thu, May 9, 2019 at 12:54 PM Mingmin Xu <mingmxus@gmail.com> wrote:
>>>
>>>> Quick ping ~~~
>>>> Can someone take a look at this PR(1)? I suppose a Kafka adapter will
>> be
>>>> very helpful to accelerate the adoption of Calcite Stream SQL.
>>>>
>>>> [1]. https://github.com/apache/calcite/pull/1127
>>>>
>>>> Mingmin
>>>>
>>>> On Wed, Apr 24, 2019 at 11:31 PM Mingmin Xu <mingmxus@gmail.com>
>> wrote:
>>>>
>>>>> Thank you @Andrei @Michael. Currently it's a straightforward
>>>>> implementation of stream ScannableTable, a site page is added for
>>> usage.
>>>>> Kindly let me know if something important is not covered.
>>>>>
>>>>> Mingmin
>>>>>
>>>>> On Wed, Apr 24, 2019 at 1:24 PM Michael Mior <mmior@apache.org>
>> wrote:
>>>>>
>>>>>> I think we'd generally be willing to accept any adapter which is
>>>>>> well-written, well-tested, and likely to be generally useful. I
>> think
>>>>>> Kafka meets the final criterion and with some work the current code
>>>>>> could meet the first two. That said, even if the adapter isn't
>>>>>> accepted into the main Calcite codebase, I would encourage you to
>>>>>> publish it as a separate package anyway.
>>>>>> --
>>>>>> Michael Mior
>>>>>> mmior@apache.org
>>>>>>
>>>>>> Le mer. 24 avr. 2019 à 08:07, Andrei Sereda <andrei@sereda.cc>
a
>>> écrit
>>>> :
>>>>>>>
>>>>>>> Hi Mingmin,
>>>>>>>
>>>>>>> I'm happy to review it.
>>>>>>>
>>>>>>> Before would like to confirm with this list that they're OK adding
>>> new
>>>>>>> adapter (kafka) to calcite codebase ?
>>>>>>>
>>>>>>> Regards,
>>>>>>> Andrei.
>>>>>>>
>>>>>>> On Tue, Apr 23, 2019 at 10:43 PM Mingmin Xu <mingmxu@apache.org>
>>>> wrote:
>>>>>>>
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> I add a new adapter for Apache Kafka, to allow users to query
>>> Kafka
>>>>>> topics
>>>>>>>> with Calcite STREAM SQL. Can someone take a look at the PR[1]?
>>>>>>>>
>>>>>>>> [1]. https://github.com/apache/calcite/pull/1127
>>>>>>>>
>>>>>>>> Thanks!
>>>>>>>> Mingmin
>>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> ----
>>>>> Mingmin
>>>>>
>>>>
>>>>
>>>> --
>>>> ----
>>>> Mingmin
>>>>
>>>
>>
>>
>> --
>> ----
>> Mingmin
>>
|