calcite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laurent Goujon (JIRA)" <>
Subject [jira] [Created] (CALCITE-3085) Unused stack field in RelShuttleImpl
Date Wed, 22 May 2019 22:48:00 GMT
Laurent Goujon created CALCITE-3085:

             Summary: Unused stack field in RelShuttleImpl
                 Key: CALCITE-3085
             Project: Calcite
          Issue Type: Bug
          Components: core
            Reporter: Laurent Goujon
            Assignee: Laurent Goujon

{{RelShuttleImpl}} class has a  protected {{stack}} field which is being populated when going
over children, but those content is actually never used. In Calcite code base, no subclasses
are actually using the content of the stack ({{CorelMapBuilder}} is populating the stack but
does not read the content back either).

Searching code on github didn't show any usage of it either (but this is not foolprof).

As maintaining this stack has a non-negligible impact on memory/performance, I would suggest
to remove the field.

This message was sent by Atlassian JIRA

View raw message