If it’s a release candidate there’s at least a 50% chance it will turn into a release.
So the release notes should be in good shape. You can make tweaks afterwards.
How about making a “release candidate” and tell reviewers that there is no chance it will
be released? You can call it RC0 if you like.
Even then, release notes help me review a release candidate, so you will get better feedback
if you have a first iteration of release notes.
Can you make sure that https://github.com/apache/calcite/commit/a2b8a7a <https://github.com/apache/calcite/commit/a2b8a7a>
has been applied to master? Danny assured me he’d fix the tag names but a few weeks ago
it didn’t look like it had been fixed.
Julian
> On May 11, 2020, at 9:06 AM, Haisheng Yuan <hyuan@apache.org> wrote:
>
> Quick question, does the RC0 need to have fully updated history.md?
>
> On 2020/05/11 13:51:53, Haisheng Yuan <hyuan@apache.org> wrote:
>> Oops, thanks for reminding. lol
>>
>> On 2020/05/11 09:41:33, Stamatis Zampetakis <zabetak@gmail.com> wrote:
>>> Previously you mentioned:
>>> ~/vlsi-release-plugins ❯❯❯ ./gradlew prepareVote -Prc=0
>>>
>>> Just to be sure for releasing Calcite you should execute ./gradlew
>>> prepareVote -Prc=0 in calcite directory (not in vlsi-release-plugins).
>>>
>>> On Mon, May 11, 2020 at 11:03 AM Haisheng Yuan <hyuan@apache.org> wrote:
>>>
>>>> Hi Stamatis,
>>>>
>>>> I tried to add all the info to the property file, still no luck:
>>>>
>>>> signing.gnupg.keyName=3CD22ABAC50DDCEF
>>>> asfCommitterId=hyuan
>>>> ghTestGitSourceUsername=test
>>>> ghTestGitSourcePassword=test
>>>> ghTestNexusUsername=test
>>>> ghTestNexusPassword=test
>>>> asfGitSourceUsername=test
>>>> asfGitSourcePassword=test
>>>> asfNexusUsername=test
>>>> asfNexusPassword=test
>>>> asfGitSourceUsername=test
>>>> asfGitSourcePassword=test
>>>> asfSvnUsername=test
>>>> asfSvnPassword=test
>>>>
>>>> useGpgCmd=true
>>>> signing.gnupg.useLegacyGpg=true
>>>>
>>>> 1: Task failed with an exception.
>>>> -----------
>>>> * What went wrong:
>>>> Execution failed for task ':initializeNexusStagingRepository'.
>>>>> Failed to find staging profile for package group: com.github.vlsi
>>>>
>>>> * Try:
>>>> Run with --stacktrace option to get the stack trace. Run with --info or
>>>> --debug option to get more log output. Run with --scan to get full insights.
>>>>
>>>> ==============================================================================
>>>>
>>>> 2: Task failed with an exception.
>>>> -----------
>>>> * What went wrong:
>>>> Execution failed for task
>>>> ':plugins:crlf-plugin:signCrlfPluginMarkerMavenPublication'.
>>>>> Process 'command 'gpg'' finished with non-zero exit value 2
>>>>
>>>> * Try:
>>>> Run with --stacktrace option to get the stack trace. Run with --info or
>>>> --debug option to get more log output. Run with --scan to get full insights.
>>>>
>>>> ==============================================================================
>>>>
>>>> 3: Task failed with an exception.
>>>> -----------
>>>> * What went wrong:
>>>> Execution failed for task
>>>> ':plugins:checksum-dependency-plugin:signChecksum-dependencyPluginMarkerMavenPublication'.
>>>>> Process 'command 'gpg'' finished with non-zero exit value 2
>>>>
>>>> Thanks,
>>>> Haisheng
>>>>
>>>> On 2020/05/11 08:41:16, Stamatis Zampetakis <zabetak@gmail.com> wrote:
>>>>> Hi Haisheng,
>>>>>
>>>>> You might be missing some gradle.properties especially those required
to
>>>>> identify your PGP key.
>>>>>
>>>>> Have a look in the discussion in [1]. Among other info it contains also
>>>> the
>>>>> complete list of properties.
>>>>>
>>>>> Best,
>>>>> Stamatis
>>>>>
>>>>> [1]
>>>>>
>>>> https://lists.apache.org/thread.html/r71feef9a44c1f4ea0f2211dc8c74b25dab143d2e3215cf7ffcfd6f56%40%3Cdev.calcite.apache.org%3E
>>>>>
>>>>> On Mon, May 11, 2020 at 9:55 AM Haisheng Yuan <hyuan@apache.org>
wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I saw this error during the dry-run:
>>>>>> ~/vlsi-release-plugins ❯❯❯ ./gradlew prepareVote -Prc=0
>>>>>>> Task :plugins:crlf-plugin:signCrlfPluginMarkerMavenPublication
FAILED
>>>>>>> Task
>>>>>>
>>>> :plugins:checksum-dependency-plugin:signChecksum-dependencyPluginMarkerMavenPublication
>>>>>> FAILED
>>>>>>> Task :initializeNexusStagingRepository FAILED
>>>>>>
>>>>>> FAILURE: Build completed with 3 failures.
>>>>>>
>>>>>> 1: Task failed with an exception.
>>>>>> -----------
>>>>>> * What went wrong:
>>>>>> Execution failed for task
>>>>>> ':plugins:crlf-plugin:signCrlfPluginMarkerMavenPublication'.
>>>>>>> Cannot perform signing task
>>>>>> ':plugins:crlf-plugin:signCrlfPluginMarkerMavenPublication' because
it
>>>> has
>>>>>> no configured signatory
>>>>>>
>>>>>> * Try:
>>>>>> Run with --stacktrace option to get the stack trace. Run with --info
or
>>>>>> --debug option to get more log output. Run with --scan to get full
>>>> insights.
>>>>>>
>>>>>>
>>>> ==============================================================================
>>>>>>
>>>>>> 2: Task failed with an exception.
>>>>>> -----------
>>>>>> * What went wrong:
>>>>>> Execution failed for task
>>>>>>
>>>> ':plugins:checksum-dependency-plugin:signChecksum-dependencyPluginMarkerMavenPublication'.
>>>>>>> Cannot perform signing task
>>>>>>
>>>> ':plugins:checksum-dependency-plugin:signChecksum-dependencyPluginMarkerMavenPublication'
>>>>>> because it has no configured signatory
>>>>>>
>>>>>> * Try:
>>>>>> Run with --stacktrace option to get the stack trace. Run with --info
or
>>>>>> --debug option to get more log output. Run with --scan to get full
>>>> insights.
>>>>>>
>>>>>>
>>>> ==============================================================================
>>>>>>
>>>>>> 3: Task failed with an exception.
>>>>>> -----------
>>>>>> * What went wrong:
>>>>>> Execution failed for task ':initializeNexusStagingRepository'.
>>>>>>> Failed to find staging profile for package group: com.github.vlsi
>>>>>>
>>>>>> Here is the gradle.properties settings:
>>>>>> ghTestGitSourceUsername=test
>>>>>> ghTestGitSourcePassword=test
>>>>>> ghTestNexusUsername=test
>>>>>> ghTestNexusPassword=test
>>>>>>
>>>>>>
>>>>>> BTW, my gpg public key has been uploaded:
>>>>>>
>>>> https://pgp.mit.edu/pks/lookup?search=0x3CD22ABAC50DDCEF&op=vindex&exact=on
>>>>>>
>>>>>> And the gpg fingerprint has been updated in my apache id profile
at
>>>>>> https://id.apache.org/.
>>>>>>
>>>>>> Any kind of help is appreciated.
>>>>>>
>>>>>> Thanks,
>>>>>> Haisheng
>>>>>>
>>>>>> On 2020/05/06 02:09:11, Chunwei Lei <chunwei.leii@gmail.com>
wrote:
>>>>>>> Hi, Haisheng, I would like to review the PR for CALCITE-3896.
>>>>>>>
>>>>>>>
>>>>>>> Best,
>>>>>>> Chunwei
>>>>>>>
>>>>>>>
>>>>>>> On Wed, May 6, 2020 at 4:50 AM Rui Wang <amaliujia@apache.org>
>>>> wrote:
>>>>>>>
>>>>>>>> Thanks for leading 1.23.0 release, Haisheng!
>>>>>>>>
>>>>>>>> I will actively contact Danny and Feng to see if we can reach
a
>>>>>> conclusion
>>>>>>>> on https://github.com/apache/calcite/pull/1761 by next monday.
>>>>>>>>
>>>>>>>>
>>>>>>>> -Rui
>>>>>>>>
>>>>>>>> On Tue, May 5, 2020 at 11:31 AM Haisheng Yuan <hyuan@apache.org>
>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Yes, no problem. Will have a RC before next Monday, PDT.
>>>>>>>>>
>>>>>>>>> @Roman, thanks for helping.
>>>>>>>>> This is the PR: https://github.com/apache/calcite/pull/1953
>>>>>>>>>
>>>>>>>>> Haisheng
>>>>>>>>>
>>>>>>>>> On 2020/05/05 14:57:48, Julian Hyde <jhyde.apache@gmail.com>
>>>> wrote:
>>>>>>>>>> Thanks for volunteering, Haisheng.
>>>>>>>>>>
>>>>>>>>>> Before everyone piles in with wish-lists, can we
set a
>>>> timescale
>>>>>> for
>>>>>>>> the
>>>>>>>>> release?
>>>>>>>>>>
>>>>>>>>>> I would suggest an aggressive timescale, for example
an RC a
>>>> week
>>>>>> from
>>>>>>>>> today. Hold the RC only for mandatory cases. Other stuff
gets in
>>>> if
>>>>>> it’s
>>>>>>>>> ready.
>>>>>>>>>>
>>>>>>>>>> Julian
>>>>>>>>>>
>>>>>>>>>>> On May 5, 2020, at 5:51 AM, Ruben Q L <rubenql@gmail.com>
>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Thanks for starting the discussion, Stamatis.
>>>>>>>>>>>
>>>>>>>>>>> Just a reminder that there is a blocking issue
[1] that
>>>> needs to
>>>>>> be
>>>>>>>>> solved
>>>>>>>>>>> (it is a regression introduced after 1.22).
>>>>>>>>>>> Apart from that, it would be nice if we could
include [2] in
>>>>>> 1.23.
>>>>>>>>>>>
>>>>>>>>>>> Best regards,
>>>>>>>>>>> Ruben
>>>>>>>>>>>
>>>>>>>>>>> [1] https://issues.apache.org/jira/browse/CALCITE-3926
>>>>>>>>>>> [2] https://issues.apache.org/jira/browse/CALCITE-3951
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>> Le mar. 5 mai 2020 à 12:34, Roman Kondakov
>>>>>>>> <kondakov87@mail.ru.invalid>
>>>>>>>>> a
>>>>>>>>>>>> écrit :
>>>>>>>>>>>>
>>>>>>>>>>>> Hi Haisheng,
>>>>>>>>>>>>
>>>>>>>>>>>> I would like to review CALCITE-3896. Do you
have a PR?
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Kind Regards
>>>>>>>>>>>> Roman Kondakov
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>> On 05.05.2020 06:37, Haisheng Yuan wrote:
>>>>>>>>>>>>> IIRC, I am the release manager for 1.23.0.
>>>>>>>>>>>>>
>>>>>>>>>>>>> I think CALCITE-3896 (top-down trait
request) is in good
>>>>>> shape, it
>>>>>>>>> will
>>>>>>>>>>>> be nice if it can go into 1.23.0. Can someone
help review?
>>>>>>>>>>>>>
>>>>>>>>>>>>> On 2020/05/04 22:58:25, Stamatis Zampetakis
<
>>>> zabetak@gmail.com
>>>>>>>
>>>>>>>>> wrote:
>>>>>>>>>>>>>> Hello,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Calcite 1.22.0 was released about
2 months ago (on March
>>>> 5,
>>>>>> 2020).
>>>>>>>>>>>> During
>>>>>>>>>>>>>> the vote we said to try to have a
release sooner than
>>>> usual
>>>>>> so I
>>>>>>>> am
>>>>>>>>>>>>>> launching the discussion now hoping
we could get to 1.23.0
>>>>>> rather
>>>>>>>>> soon.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I was checking the status of the
current release [1] and
>>>> we
>>>>>> have
>>>>>>>>> already
>>>>>>>>>>>>>> over 100 resolved issues with 91
fixes so it is already
>>>> pretty
>>>>>>>> big.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I know that there quite a few discussions
in progress so
>>>> it
>>>>>> would
>>>>>>>> be
>>>>>>>>>>>> good
>>>>>>>>>>>>>> to see how many of the ongoing cases
should be fixed for
>>>>>> 1.23.0.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> More importantly do we have a release
manager for 1.23.0?
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Best,
>>>>>>>>>>>>>> Stamatis
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> [1]
>>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>
>>>> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
>>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
|