calcite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesus Camacho Rodriguez (Jira)" <j...@apache.org>
Subject [jira] [Created] (CALCITE-3999) Simplify DialectPool implementation
Date Thu, 14 May 2020 01:27:00 GMT
Jesus Camacho Rodriguez created CALCITE-3999:
------------------------------------------------

             Summary: Simplify DialectPool implementation
                 Key: CALCITE-3999
                 URL: https://issues.apache.org/jira/browse/CALCITE-3999
             Project: Calcite
          Issue Type: Improvement
          Components: core
            Reporter: Jesus Camacho Rodriguez
            Assignee: Jesus Camacho Rodriguez


JdbcUtils contains a pool to cache SqlDialect objects. Currently, it relies on multiple maps
and a synchronized {{get}} method. Although I am not very familiar with that code, it seems
the implementation could be made simpler and more efficient by using a Guava cache. In addition,
since we would not have a single synchronized get method, multiple threads could concurrently
create dialects for distinct data sources.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message