carbondata-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kunalkap...@apache.org
Subject carbondata git commit: [HOTFIX][32K]maintain proper mapping for varChar Columns and noDictionary Columns for all the dimensions while creating sort data rows instance
Date Wed, 04 Jul 2018 06:24:32 GMT
Repository: carbondata
Updated Branches:
  refs/heads/master cd7c2102c -> 5195d7f50


[HOTFIX][32K]maintain proper mapping for varChar Columns and noDictionary Columns
for all the dimensions while creating sort data rows instance

Problem: when creating the column mapping for varChar columns and no dictionary
 columns for existing dimensions, the mapping is incorrect.

Solution: remove unwanted variable counter and map correct index to varChar columns
 and noDictionary columns based on the number of dimensions

This closes #2395


Project: http://git-wip-us.apache.org/repos/asf/carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/carbondata/commit/5195d7f5
Tree: http://git-wip-us.apache.org/repos/asf/carbondata/tree/5195d7f5
Diff: http://git-wip-us.apache.org/repos/asf/carbondata/diff/5195d7f5

Branch: refs/heads/master
Commit: 5195d7f506eb5b74272d100afb08d55daf129be6
Parents: cd7c210
Author: akashrn5 <akashnilugal@gmail.com>
Authored: Thu Jun 21 18:57:07 2018 +0530
Committer: kunal642 <kunalkapoor642@gmail.com>
Committed: Wed Jul 4 11:52:46 2018 +0530

----------------------------------------------------------------------
 .../processing/merger/CompactionResultSortProcessor.java       | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/carbondata/blob/5195d7f5/processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
----------------------------------------------------------------------
diff --git a/processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
b/processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
index 9dab181..ff4e47b 100644
--- a/processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
+++ b/processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
@@ -359,16 +359,16 @@ public class CompactionResultSortProcessor extends AbstractResultProcessor
{
     noDictionaryColMapping = new boolean[dimensions.size()];
     isVarcharDimMapping = new boolean[dimensions.size()];
     int i = 0;
-    int j = 0;
     for (CarbonDimension dimension : dimensions) {
       if (CarbonUtil.hasEncoding(dimension.getEncoder(), Encoding.DICTIONARY)) {
         i++;
         continue;
       }
-      noDictionaryColMapping[i++] = true;
+      noDictionaryColMapping[i] = true;
       if (dimension.getColumnSchema().getDataType() == DataTypes.VARCHAR) {
-        isVarcharDimMapping[j++] = true;
+        isVarcharDimMapping[i] = true;
       }
+      i++;
       noDictionaryCount++;
     }
     dimensionColumnCount = dimensions.size();


Mime
View raw message