carbondata-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kumarvisha...@apache.org
Subject carbondata git commit: [CARBONDATA-3212] Fixed NegativeArraySizeException while querying in specific scenario
Date Thu, 03 Jan 2019 05:37:39 GMT
Repository: carbondata
Updated Branches:
  refs/heads/master f8697b106 -> deb08c329


[CARBONDATA-3212] Fixed NegativeArraySizeException while querying in specific scenario

Problem:In Local Dictionary, page size was not getting updated for complex children columns.
So during fallback,
new page was being created with less records giving NegativeArraySizeException while querying
data.

Solution:Updated the page size in Local Dictionary.

This closes#3031


Project: http://git-wip-us.apache.org/repos/asf/carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/carbondata/commit/deb08c32
Tree: http://git-wip-us.apache.org/repos/asf/carbondata/tree/deb08c32
Diff: http://git-wip-us.apache.org/repos/asf/carbondata/diff/deb08c32

Branch: refs/heads/master
Commit: deb08c329287dc7bcdf96af6a6611f7c4b0fc83a
Parents: f8697b1
Author: shivamasn <shivamasn17@gmail.com>
Authored: Wed Jan 2 16:19:22 2019 +0530
Committer: kumarvishal09 <kumarvishal1802@gmail.com>
Committed: Thu Jan 3 11:06:59 2019 +0530

----------------------------------------------------------------------
 .../carbondata/core/datastore/page/LocalDictColumnPage.java       | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/carbondata/blob/deb08c32/core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java
b/core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java
index 5cf2130..0e34d72 100644
--- a/core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java
+++ b/core/src/main/java/org/apache/carbondata/core/datastore/page/LocalDictColumnPage.java
@@ -140,6 +140,9 @@ public class LocalDictColumnPage extends ColumnPage {
     } else {
       actualDataColumnPage.putBytes(rowId, bytes);
     }
+    if (pageSize <= rowId) {
+      pageSize = rowId + 1;
+    }
   }
 
   @Override public void disableLocalDictEncoding() {


Mime
View raw message