carbondata-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ravipes...@apache.org
Subject [carbondata] 25/41: [CARBONDATA-3302] [Spark-Integration] code cleaning related to CarbonCreateTable command
Date Tue, 02 Apr 2019 02:41:45 GMT
This is an automated email from the ASF dual-hosted git repository.

ravipesala pushed a commit to branch branch-1.5
in repository https://gitbox.apache.org/repos/asf/carbondata.git

commit 15f13ad3d7b0b1fedcb460f1bdb8f48eddd27003
Author: s71955 <sujithchacko.2010@gmail.com>
AuthorDate: Sun Feb 24 21:45:16 2019 +0530

    [CARBONDATA-3302] [Spark-Integration] code cleaning related to CarbonCreateTable command
    
    What changes were proposed in this pull request?
    Removed Extra check to validate whether the stream relation is not null , moreover condition
can be optimized further,
    currently the condition has path validation whether path is part of s3 file system and
then system is checking
    whether the stream relation is not null, this check can be added initially as this overall
    condition has to be evaluated for stream table only if stream is not null.
    
    This closes #3134
---
 .../spark/sql/execution/command/table/CarbonCreateTableCommand.scala   | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonCreateTableCommand.scala
b/integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonCreateTableCommand.scala
index 12eb420..1e17ffe 100644
--- a/integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonCreateTableCommand.scala
+++ b/integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonCreateTableCommand.scala
@@ -78,8 +78,7 @@ case class CarbonCreateTableCommand(
         path
       }
       val streaming = tableInfo.getFactTable.getTableProperties.get("streaming")
-      if (path.startsWith("s3") && streaming != null && streaming != null
&&
-          streaming.equalsIgnoreCase("true")) {
+      if (streaming != null && streaming.equalsIgnoreCase("true") && path.startsWith("s3"))
{
         throw new UnsupportedOperationException("streaming is not supported with s3 store")
       }
       tableInfo.setTablePath(tablePath)


Mime
View raw message