cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Masood Mortazavi (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (CASSANDRA-1178) get_slice calls do not close files when finished resulting in "too many open files" exceptions and rendering C unusable
Date Thu, 10 Jun 2010 03:55:16 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877305#action_12877305
] 

Masood Mortazavi edited comment on CASSANDRA-1178 at 6/9/10 11:54 PM:
----------------------------------------------------------------------

Sounds reasonable . . . 

It seems to me that he idea is that 

(1) If you pass a non-null file object reference to the constructor, you are the best judge
of when to close it. 

(2) If you pass a null, instead, you will have to ask SSTableSliceIterator to clean up after
you're done by calling "close" on it. 

This is then the semantics of this class when it comes to the file variable. 

I think it may be useful to include this contractual/semantic fact in the javadoc for this
class. 

(Side note: It would probably be best not to allow IDE's to change the order of imports from
the one that's common everywhere else unless there is a policy by this project to make such
reordering. It is better to keep things consistent.)



      was (Author: mortazavi):
    Sounds reasonable . . . 

It seems to me that he idea is that 

(1) If you pass a non-null file object reference to the constructor, you are the best judge
of when to close it. 

(2) If you pass a null, instead, you will have to ask SSTableSliceIterator to clean up after
you're done by calling "close" on it. 

This is then the semantics of this class. 

I think it may be useful to include this contractual fact in the javadoc for this class. 

(Side note: It would probably be best not to allow IDE's to change the order of imports from
the one that's common everywhere else unless there is a policy by this project to make such
reordering. It is better to keep things consistent.)


  
> get_slice calls do not close files when finished resulting in "too many open files" exceptions
and rendering C unusable
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-1178
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1178
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7
>            Reporter: Matthew F. Dennis
>            Assignee: Matthew F. Dennis
>             Fix For: 0.7
>
>         Attachments: 0001-trunk-1178.patch
>
>
> insert ~100K rows.  Read them back in a loop.  Notice "too many open files" exceptions
in log.  SSTableSliceIterator is never closing the files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message