cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew F. Dennis (JIRA)" <j...@apache.org>
Subject [jira] Updated: (CASSANDRA-1200) additional BRAF tests
Date Sun, 20 Jun 2010 07:22:24 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matthew F. Dennis updated CASSANDRA-1200:
-----------------------------------------

    Attachment: trunk-1200.txt

I don't think that statement says anything about the expected behavior when a request to read
more bytes than will fit into the array is made.

However, the contract in the javadoc does specify that IndexOutOfBoundsException will be thrown
when len > buf.length - offset (which is consistent with the behavior of java.io.RandomAccessFile).
 Being an unchecked exception, I hadn't expected this to be part of the contract (I actually
think IllegalArgumentException is more descriptive for this scenario since the impossible
was requested).  The tests for IAE have been removed, leaving only the EOF tests.


> additional BRAF tests
> ---------------------
>
>                 Key: CASSANDRA-1200
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1200
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 0.7
>            Reporter: Matthew F. Dennis
>            Assignee: Matthew F. Dennis
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: trunk-1200.txt
>
>
> In comments/IRC there was some concern about BRAF.readFully() raising EOFException when
appropriate

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message