cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <>
Subject [jira] Updated: (CASSANDRA-615) refactor o.a.c.cli.CliClient
Date Sat, 23 Oct 2010 05:02:12 GMT


Jonathan Ellis updated CASSANDRA-615:

    Fix Version/s: 0.7.1
         Assignee: Pavel Yaskevich  (was: Roger Schildmeijer)

Pavel, what do you think?

> refactor o.a.c.cli.CliClient
> ----------------------------
>                 Key: CASSANDRA-615
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Eric Evans
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>             Fix For: 0.7.1
> There is a lot of code duplication when it comes to decomposing commands into keyspace,
column family, keys, columns, etc, and validating the results. There would be even more if
the error handling was more thorough.
> I think the cleanest way is to create a class that accepts a CommonTree in its constructor
and assigns the results to members. A custom exception can be thrown for validation errors
and CliClient can simply trap these, print the descriptive .msg, and return.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message