cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Alves (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-3885) Support multiple ranges in SliceQueryFilter
Date Wed, 06 Jun 2012 10:20:24 GMT


David Alves commented on CASSANDRA-3885:

Hi Jonathan.

I'm sorry I wasn't able to explain myself better. It's not that I wouldn't want to change
things, it's that the most straightforward to use the same add cols and then recheck approach
is to add more checks to the isColumnNeeded method and that is not a good idea since it is
pretty convoluted and slow as is (ran some tests and the cache version vs the add the recheck
version is about 5-10% faster about 5 on forward reads and 10 on reverse).

Still in retrospective the code surely be improved lot in terms or readability and Sylvain
has made a couple of interesting suggestions that I'm trying out, hopefully we'll get the
best of both worlds.

> Support multiple ranges in SliceQueryFilter
> -------------------------------------------
>                 Key: CASSANDRA-3885
>                 URL:
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: David Alves
>             Fix For: 1.2
>         Attachments: CASSANDRA-3885.patch, CASSANDRA-3885.patch, CASSANDRA-3885.patch
> This is logically a subtask of CASSANDRA-2710, but Jira doesn't allow sub-sub-tasks.
> We need to support multiple ranges in a SliceQueryFilter, and we want querying them to
be efficient, i.e., one pass through the row to get all of the ranges, rather than one pass
per range.
> Supercolumns are irrelevant since the goal is to replace them anyway.  Ignore supercolumn-related
code or rip it out, whichever is easier.
> This is ONLY dealing with the storage engine part, not the StorageProxy and Command intra-node
messages or the Thrift or CQL client APIs.  Thus, a unit test should be added to ColumnFamilyStoreTest
to demonstrate that it works.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message