cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-3974) Per-CF TTL
Date Fri, 09 Nov 2012 17:22:13 GMT


Sylvain Lebresne commented on CASSANDRA-3974:

I realize I'm reviewer on this one. I seem that remember that [~jbellis] wanted to have a
look at that but maybe I misunderstood that?

In any case, I had a look at that patch and that looks good to me overall. That being, and
that's not really a criticism of the patch, I do was slightly surprised that we only need
to modify {{ColumnFamily.addColumn(QueryPath, ...)}} and {{InsertStatement}} to make that
work. Don't get me wrong, I do think this is correct, but it does feel a bit fragile that
some future internal code could too easily add an ExpiringColumn though ColumnFamily.addColumn(IColumn)
and skip the global cf setting. I don't really have any good solution to make it less fragile
however, I'm just thinking out loud. But that remark aside, again the patch does lgtm (aside
from needing rebase).
> Per-CF TTL
> ----------
>                 Key: CASSANDRA-3974
>                 URL:
>             Project: Cassandra
>          Issue Type: New Feature
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Jonathan Ellis
>            Assignee: Kirk True
>            Priority: Minor
>             Fix For: 1.2.0 rc1
>         Attachments: trunk-3974.txt, trunk-3974v2.txt, trunk-3974v3.txt, trunk-3974v4.txt,
trunk-3974v5.txt, trunk-3974v6.txt
> Per-CF TTL would allow compaction optimizations ("drop an entire sstable's worth of expired
data") that we can't do with per-column.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message