cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5019) Still too much object allocation on reads
Date Fri, 21 Dec 2012 08:27:12 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537758#comment-13537758
] 

Sylvain Lebresne commented on CASSANDRA-5019:
---------------------------------------------

I'm really not a fan. Doing that means we break the 'Column is an immutable object' assumption
and it would make getting code right much harder. Typically, for a ColumnFamily backed byt
such backing FlyweightColumns, you'd have to be extra careful when using it to never alias
a Column returned during iteration because that alias would be invalidated by the next step
of the iteration itself. I'm really afraid this would make it far too easy to get subtle bugs.

Unless it can be demonstrated that such a thing brings concrete and substantial performance
benefits, I think I'm -1 on it cause it would make imo the code too much fragile.
                
> Still too much object allocation on reads
> -----------------------------------------
>
>                 Key: CASSANDRA-5019
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5019
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>             Fix For: 2.0
>
>
> ArrayBackedSortedColumns was a step in the right direction but it's still relatively
heavyweight thanks to allocating individual Columns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message