cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-4767) Need some indication of node repair success or failure
Date Wed, 02 Jan 2013 14:24:18 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542135#comment-13542135
] 

Sylvain Lebresne commented on CASSANDRA-4767:
---------------------------------------------

My last minor nit is that while a given RepairRunner don't count other repair notifications,
it still prints their messages which I'd prefer avoiding. But with that fixed, +1 on the patch.
Now given how advanced we are in the 1.1 cycle, my own choice would be to just go for 1.2,
but since I don't think this can break things in any major way I won't oppose pushing in 1.1
either.

bq. I think we need to keep blocking repair methods for backward compatibility

I agree. When I talked about duplication, I was talking of the body of the methods themselves.
By that I mean that forceRepairAsync and forceTableRepair have roughtly the same body (or
rather forceRepairAsync is a subset as it sends the notifications, but it wouldn't matter
if forceTableRepair was sending notification too). We could imagine fixing that code duplication.
But that being said, it'll fix itself if we remove the blocking methods in a latter release
so I'm fine not bothering with that for now.

bq. the patch modifies behavior of repair command in the way that it outputs repair progress

Do you mean what is logged? If so, I agree it's likely not a problem.


                
> Need some indication of node repair success or failure
> ------------------------------------------------------
>
>                 Key: CASSANDRA-4767
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4767
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Ahmed Bashir
>            Assignee: Yuki Morishita
>            Priority: Minor
>              Labels: jmx
>             Fix For: 1.1.9
>
>         Attachments: 4767-1.1.txt, 4767-1.1-v2.txt
>
>
> We are currently verifying node repair status via basic log analysis.  In order to automatically
track the status of periodic node repair jobs, it would be better to have an indicator (through
JMX perhaps).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message