cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-6117) Avoid death-by-tombstone by default
Date Tue, 01 Oct 2013 15:37:24 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783058#comment-13783058
] 

Sylvain Lebresne commented on CASSANDRA-6117:
---------------------------------------------

I agree that keeping the warning and setting the error threshold higher is better. Still not
totally at peace with the idea of erroring out, but I agree the new defaults leave plenty
of time to be warned before the error threshold kicks in so ...

Few minor points on the last patch:
* the NEWS file change should probably mention the 2 settings.
* the defaults aren't up to date in Config.java.
* might want to point to tombstone_failure_threshold in the error log like you've added for
the warning threshold.
* shouldn't we also catch and skip TombstoneOverwhelmingException in ReadVerbHandler to avoid
double logging?


> Avoid death-by-tombstone by default
> -----------------------------------
>
>                 Key: CASSANDRA-6117
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6117
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 2.0.2
>
>         Attachments: 6117.txt, 6117-v2.txt, 6117-v3.txt
>
>
> We added warnings to 1.2 (CASSANDRA-6042); for 2.0 we should go farther and drop requests
(with an error logged) that exceed the threshold.  Users who want to tread dangerously are
free to crank the threshold up, but "I queried a lot of tombstones and Cassandra fell over"
is possibly the number one way of killing Cassandra nodes right now.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message