cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Clément Lardeur (JIRA) <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-6381) Refactor nodetool
Date Thu, 09 Jan 2014 15:30:51 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Clément Lardeur updated CASSANDRA-6381:
---------------------------------------

    Attachment: trunk-6381-v3.patch

+Commands+

h6. REBUILD_INDEX 

Fix description. Space separated values. 
{code}
(IndexNameExample: Standard3.IdxName Standard3.IdxName1)
{code}

h6. SETCOMPACTIONTHRESHOLD

Revert to the initial condition.
min == max == 0 is now possible but this is a deprecated use case.
See {{ColumnFamilyStore.validateCompactionThresholds()}}).

h6. STATUS

My bad, it's a refactoring error, I inlined the {{dc}} var.

{code:java}
String dc = epSnitchInfo.getDatacenter(ownership.ip);
{code}

h6. TRUNCATEHINTS

Convert the list to a string.

{code:java}
@Arguments(usage = "[endpoint]", description = "Endpoint address to delete hints for, either
ip address (\"127.0.0.1\") or hostname")
private String endpoint = EMPTY;
{code}


+Print history+

This is an oversight on my part, it is added.


> Refactor nodetool
> -----------------
>
>                 Key: CASSANDRA-6381
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6381
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Yuki Morishita
>            Assignee: Clément Lardeur
>            Priority: Minor
>              Labels: lhf, nodetool
>         Attachments: trunk-6381-v2.patch, trunk-6381-v3.patch, trunk-6381.patch
>
>
> We have way too many nodetool commands(more than 40) packed in one NodeCmd class. And
we are trying to add more commands.
> https://github.com/airlift/airline could be a good fit to take out each command into
sub command class.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message