cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Clément Lardeur (JIRA) <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-6381) Refactor nodetool
Date Fri, 10 Jan 2014 12:52:52 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Clément Lardeur updated CASSANDRA-6381:
---------------------------------------

    Attachment: trunk-6381-v4.patch

bq. Would it be better to keep only valid commands in the history?

I agree, it's done.

bq. The only open question we have is which condition for REPAIR is correct?

I reverted to the old version to not include functional change from a refactoring. If the
condition is really wrong, I think it's better to open a new JIRA.

Thanks [~mishail] for your suggestions, it's better like this. :)



> Refactor nodetool
> -----------------
>
>                 Key: CASSANDRA-6381
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6381
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Yuki Morishita
>            Assignee: Clément Lardeur
>            Priority: Minor
>              Labels: lhf, nodetool
>         Attachments: trunk-6381-v2.patch, trunk-6381-v3.patch, trunk-6381-v4.patch, trunk-6381.patch
>
>
> We have way too many nodetool commands(more than 40) packed in one NodeCmd class. And
we are trying to add more commands.
> https://github.com/airlift/airline could be a good fit to take out each command into
sub command class.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message