cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7859) Extend freezing to collections
Date Tue, 04 Nov 2014 11:14:34 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196001#comment-14196001
] 

Sylvain Lebresne commented on CASSANDRA-7859:
---------------------------------------------

Mostly look good, last few minor remarks:
* It needs a minor rebase
* {{SelectStatement.getRequestedColumns}} still has the unrelated code. Haven't really reviewed
it so would be nice to pull it out for some other ticket.
* I kind of like the idea of shortening {{fullcollection}} to {{full}}, let's do that (unless
someone else chime in with a better suggestion).
* I don't think we need {{CollectionType.isValidCompatibleWithInternal}} at all since it's
equivalent to {{isCompatibleWith}}.
* We could now add a {{assert !isMultiCell}} in the collections {{compare()}} method.

I'll note that part of me feels like this might be a bit too big for 2.1, but there is a fair
amount of tests so I'm not strongly opposed to it either.

> Extend freezing to collections
> ------------------------------
>
>                 Key: CASSANDRA-7859
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7859
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sylvain Lebresne
>            Assignee: Tyler Hobbs
>              Labels: cql
>             Fix For: 2.1.2
>
>         Attachments: 7859-v1.txt
>
>
> This is the follow-up to CASSANDRA-7857, to extend {{frozen}} to collections. This will
allow things like {{map<text, frozen<map<int, int>>>}} for instance, as
well as allowing {{frozen}} collections in PK columns.
> Additionally (and that's alsmot a separate ticket but I figured we can start discussing
it here), we could decide that tuple is a frozen type by default. This means that we would
allow {{tuple<int, text>}} without needing to add {{frozen}}, but we would require {{frozen}}
for complex type inside tuple, so {{tuple<int, list<text>>}} would be rejected,
but not {{tuple<int, frozen<list<text>>>}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message