cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10098) Windows dtest 3.0: commitlog_test.py:TestCommitLog.small_segment_size_test fails
Date Fri, 28 Aug 2015 22:31:46 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720698#comment-14720698
] 

Paulo Motta commented on CASSANDRA-10098:
-----------------------------------------

Created a [cassandra-dtest PR|https://github.com/riptano/cassandra-dtest/pull/521] with a
proposal to make the commit log segment size more deterministic.

Since the main objective of these tests is to verify that the {{commitlog_segment_size_in_mb}}
property is respected, I removed the checks for number of commit log files and total commit
log size, since these may greatly vary on different test runs, environments, cassandra versions
and compression settings, so there's a lot of variation. There are other tests that test commit
log integrity, so I don't think it's crucial to test these attributes on these tests.

Since compressed commit log segment sizes may also vary depending on different factors, I
modified the test to check that the compressed commit log segment size is within \[segment_size/2,
segment_size\], so we accept a maximum of 50% compression ratio for compressed segments.

> Windows dtest 3.0: commitlog_test.py:TestCommitLog.small_segment_size_test fails
> --------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-10098
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10098
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Joshua McKenzie
>            Assignee: Paulo Motta
>              Labels: Windows
>             Fix For: 3.0 beta 1
>
>
> {noformat}
>   File "D:\Python27\lib\unittest\case.py", line 329, in run
>     testMethod()
>   File "D:\jenkins\workspace\cassandra-3.0_dtest_win32\cassandra-dtest\tools.py", line
243, in wrapped
>     f(obj)
>   File "D:\jenkins\workspace\cassandra-3.0_dtest_win32\cassandra-dtest\commitlog_test.py",
line 226, in small_segment_size_test
>     self._commitlog_test(segment_size_in_mb, 62.5, 13, files_error=0.2)
>   File "D:\jenkins\workspace\cassandra-3.0_dtest_win32\cassandra-dtest\commitlog_test.py",
line 99, in _commitlog_test
>     error=files_error)
>   File "D:\jenkins\workspace\cassandra-3.0_dtest_win32\cassandra-dtest\assertions.py",
line 62, in assert_almost_equal
>     assert vmin > vmax * (1.0 - error) or vmin == vmax, "values not within %.2f%%
of the max: %s" % (error * 100, args)
> 'values not within 20.00% of the max: (10, 13)\n-------------------- >> begin captured
logging << --------------------\ndtest: DEBUG: cluster ccm directory: d:\\temp\\dtest-qnguzs\n---------------------
>> end captured logging << ---------------------'
> {noformat}
> Failure history: [consistent|http://cassci.datastax.com/view/cassandra-3.0/job/cassandra-3.0_dtest_win32/17/testReport/junit/commitlog_test/TestCommitLog/small_segment_size_test/]
> env: Both ci and local



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message