cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joel Knighton (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-11168) Hint Metrics are updated even if hinted_hand-offs=false
Date Mon, 07 Mar 2016 18:20:40 GMT


Joel Knighton commented on CASSANDRA-11168:

Yes, this accomplishes the desired behavior with regard to the metric.

It isn't clear to me why the changes to the scope of the if from the original code are needed.
Is there a change in logical behavior or is it just a suggested code style change?

I think a patch that simply removes the metric increment in the case of early returns due
to hinted handoff being disabled would be sufficient.

> Hint Metrics are updated even if hinted_hand-offs=false
> -------------------------------------------------------
>                 Key: CASSANDRA-11168
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Anubhav Kale
>            Assignee: Anubhav Kale
>            Priority: Minor
>         Attachments: 0001-Hinted-Handoff-Fix.patch
> In our PROD logs, we noticed a lot of hint metrics even though we have disabled hinted
> The reason is StorageProxy.ShouldHint has an inverted if condition. 
> We should also wrap the if (hintWindowExpired) block in if (DatabaseDescriptor.hintedHandoffEnabled()).
> The fix is easy, and I can provide a patch.

This message was sent by Atlassian JIRA

View raw message