cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11548) Anticompaction not removing old sstables
Date Tue, 19 Apr 2016 11:10:25 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247563#comment-15247563
] 

Paulo Motta commented on CASSANDRA-11548:
-----------------------------------------

I prepared for commit on 2.1.15 on two commits (to preserve authors), please hold commit until
there is a decision if this can still go on 2.1.14 (which is already tagged).

Also, when you have time could you have a look on CASSANDRA-9935 which is complementary to
this?

Thank you [~krummas]!

> Anticompaction not removing old sstables
> ----------------------------------------
>
>                 Key: CASSANDRA-11548
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11548
>             Project: Cassandra
>          Issue Type: Bug
>         Environment: 2.1.13
>            Reporter: Ruoran Wang
>         Attachments: 0001-cassandra-2.1.13-potential-fix.patch
>
>
> 1. 12/29/15 https://issues.apache.org/jira/browse/CASSANDRA-10831
> Moved markCompactedSSTablesReplaced out of the loop ```for (SSTableReader sstable : repairedSSTables)```
> 2. 1/18/16 https://issues.apache.org/jira/browse/CASSANDRA-10829
> Added unmarkCompacting into the loop. ```for (SSTableReader sstable : repairedSSTables)```
> I think the effect of those above change might cause the markCompactedSSTablesReplaced
fail on 
> DataTracker.java
> {noformat}
>            assert newSSTables.size() + newShadowed.size() == newSSTablesSize :
>                 String.format("Expecting new size of %d, got %d while replacing %s by
%s in %s",
>                           newSSTablesSize, newSSTables.size() + newShadowed.size(), oldSSTables,
replacements, this);
> {noformat}
> Since change CASSANDRA-10831 moved it out. This AssertError won't be caught, leaving
the oldsstables not removed. (Then this might cause row out of order error when doing incremental
repair if there are L1 un-repaired sstables.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message