cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-11115) Thrift removal
Date Wed, 07 Dec 2016 02:27:58 GMT


Aleksey Yeschenko commented on CASSANDRA-11115:

9. {{UnfilteredRowIteratorWithLowerBound}}, {{nowInSec}} field is now unused
10. {{KeysSearcher}} now has 2 new unused imports

Have looked through everything, don't see any issues, only the listed nits.

Have three more spots to go through again, first thing tomorrow:

1. In {{LegacyLayout}}, treatment of the removed {{readAllAsDynamic}} arg as always false.
2. {{CqlInputFormat}}/{{ConfigHelper}} whether or not nulls where valid/legal before for job
range start/end keys/tokens
3. Make another pass to convince myself that the new {{TokenRange}} for {{describeRing()}}
does exactly the same thing.

Other than that I'm done, all LGTM.

> Thrift removal
> --------------
>                 Key: CASSANDRA-11115
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 4.0
> Thrift removal [has been announced for 4.0|].
This ticket is meant to serve as a general task for that removal, but also to track issue
related to that, either things that we should do in 3.x to make that removal as smooth as
possible, or sub-tasks that it makes sense to separate.

This message was sent by Atlassian JIRA

View raw message