cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Petrov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-12980) InsertUpdateIfConditionTest should test bind parameters and unset parameters
Date Wed, 07 Dec 2016 13:46:58 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-12980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15728807#comment-15728807
] 

Alex Petrov commented on CASSANDRA-12980:
-----------------------------------------

+1, thank you for the patch. 

I've ran CI just in case for [2.2|http://cassci.datastax.com/job/ifesdjeen-12980-2.2-testall/1/],
[3.0|http://cassci.datastax.com/job/ifesdjeen-12980-3.0-testall/1/] and [3.x|http://cassci.datastax.com/job/ifesdjeen-12980-3.x-testall/1/].

> InsertUpdateIfConditionTest should test bind parameters and unset parameters
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12980
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12980
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Benjamin Lerer
>            Assignee: Benjamin Lerer
>         Attachments: 12980-2.2.txt, 12980-3.0.txt
>
>
> While working on the column conditions, I realized that {{InsertUpdateIfConditionTest}}
was not testing properly the bind parameters on conditions and the {{unset}} values.
> It is an improvement but as it impacts only the unit tests, I believe it is safe to provide
a patch also for 2.2 and 3.0 to be sure to avoid any regression on those versions too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message