cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-10825) OverloadedException is untested
Date Thu, 19 Jan 2017 15:23:26 GMT


Aleksey Yeschenko commented on CASSANDRA-10825:

One other issue is that the {{LongAdder}}, used by {{Counter}}, is not a good fit for the
task. Under normal operation it's rarely being incremented, but being read multiple times
on each request. {{AtomicLong}} here is actually strictly better.

{{LongAdder}} is also not atomic, so the change isn't functionally equivalent either.

That said, I'm fine with {{LoadingCache}} here. Not with {{LongAdder}}. Perhaps putting {{AtomicLong}}
s back, but opting for {{Gauge}} s on the metrics side would be a better option?

> OverloadedException is untested
> -------------------------------
>                 Key: CASSANDRA-10825
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local Write-Read Paths
>            Reporter: Ariel Weisberg
>            Assignee: Edward Capriolo
>         Attachments: jmx-hint.png
> If you grep test/src and cassandra-dtest you will find that the string OverloadedException
doesn't appear anywhere.
> In CASSANDRA-10477 it was found that there were cases where Paxos should back-pressure
and throw OverloadedException but didn't.
> If OverloadedException is used for functional purposes then we should test that it is
thrown under expected conditions. If there are behaviors driven by catching or tracking OverloadedException
we should test those as well.

This message was sent by Atlassian JIRA

View raw message