cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13953) Switch to CRC32 for sstable metadata checksums
Date Tue, 17 Oct 2017 15:51:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207818#comment-16207818
] 

Aleksey Yeschenko commented on CASSANDRA-13953:
-----------------------------------------------

Utests had a 100% perfect run, dtests were noisy as they recently have been.

I've diffed the error report with cassci's most recent trunk run, and the following tests
failed that shouldn't have:

{code}
sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_compression_deflate_to_deflate_test
sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_compression_deflate_to_none_test
sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_compression_deflate_to_snappy_test
sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_compression_none_to_deflate_test
sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_compression_none_to_none_test
sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_compression_none_to_snappy_test
sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_compression_snappy_to_deflate_test
sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_compression_snappy_to_none_test
sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_compression_snappy_to_snappy_test
sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_uppercase_keyspace_name_test
sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_with_failing_2i_test
sstable_generation_loading_test.TestSSTableGenerationAndLoading.sstableloader_with_mv_test
jmx_test.TestJMXSSL.jmx_connection_test
jmx_test.TestJMXSSL.require_client_auth_test
repair_tests.repair_test.TestRepair.nonexistent_table_repair_test
snapshot_test.TestSnapshot.test_basic_snapshot_and_restore
snapshot_test.TestSnapshot.test_snapshot_and_restore_drop_table_remove_dropped_column
snapshot_test.TestSnapshot.test_snapshot_and_restore_dropping_a_column
upgrade_crc_check_chance_test.TestCrcCheckChanceUpgrade.crc_check_chance_upgrade_test
{code}

I ran every single one of them locally, and all of them passed (one or two are flaky and required
two attempts).

Committed to trunk as [912fdb3ea4ff58ae9e1fe0c9b230ec76273ff601|https://github.com/apache/cassandra/commit/912fdb3ea4ff58ae9e1fe0c9b230ec76273ff601].

Thanks for the review!

> Switch to CRC32 for sstable metadata checksums
> ----------------------------------------------
>
>                 Key: CASSANDRA-13953
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13953
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 4.0
>
>
> We should switch to CRC32 for sstable metadata checksumming for consistency with the
rest of the code base. There are a few other cleanups that should be done at the same time.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message