cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Dejanovski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8527) Account for range tombstones wherever we account for tombstones
Date Mon, 08 Jan 2018 09:21:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315931#comment-16315931
] 

Alexander Dejanovski commented on CASSANDRA-8527:
-------------------------------------------------

[~rustyrazorblade], 

I've simplified the patch a lot following the discussions on the dev ML. 
Counting row tombstones as "deleted rows" creates a confusion that rows shadowed by multi
row range tombstones would be counted too.
Since it's not the case (rows shadowed by RT get merged away before the ReadCommand class
and only 2 tombstone cells get counted for each RT), I've moved back to counting row tombstones
as part of the current tombstone cell counter.

Here's the updated code : https://github.com/apache/cassandra/compare/trunk...thelastpickle:CASSANDRA-8527-trace-range-tombstones

We will deal with shadowed rows in CASSANDRA-14149.

> Account for range tombstones wherever we account for tombstones
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-8527
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8527
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sylvain Lebresne
>            Assignee: Alexander Dejanovski
>             Fix For: 4.x
>
>
> As discussed in CASSANDRA-8477, we should make sure the tombstone thresholds also apply
to range tombstones, since they poses the same problems than cell tombstones.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message