cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vincent White (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14169) Trivial intellij junit run fix
Date Tue, 16 Jan 2018 04:00:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326733#comment-16326733
] 

Vincent White commented on CASSANDRA-14169:
-------------------------------------------

I wonder if we should include the rest of the parameters that are normally included by build.xml
e.g. 

{code:java}
 <jvmarg value="-Dmigration-sstable-root=${test.data}/migration-sstables"/>
 <jvmarg value="-Dcassandra.ring_delay_ms=1000"/>
 <jvmarg value="-Dcassandra.tolerate_sstable_size=true"/>
 <jvmarg value="-Dcassandra.skip_sync=true" />{code}


I don't know if it should be its own ticket, but I also noticed this the exception message
isn't particularly helpful since it outputs the wrong variable

{code: title=org.apache.cassandra.io.sstable.LegacySSTableTest#defineSchema | java}
        String scp = System.getProperty(LEGACY_SSTABLE_PROP);
        Assert.assertNotNull("System property " + LEGACY_SSTABLE_ROOT + " not set", scp);
{code}

I believe it is meant to be:

{code: title=org.apache.cassandra.io.sstable.LegacySSTableTest#defineSchema | java}
        String scp = System.getProperty(LEGACY_SSTABLE_PROP);
        Assert.assertNotNull("System property " + LEGACY_SSTABLE_PROP + " not set", scp);
{code}

> Trivial intellij junit run fix
> ------------------------------
>
>                 Key: CASSANDRA-14169
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14169
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jay Zhuang
>            Assignee: Jay Zhuang
>            Priority: Trivial
>
> Unable to run {{[LegacySSTableTest|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/io/sstable/LegacySSTableTest.java#L63]}}
in the Intellij, because the {{[legacy-sstable-root|https://github.com/apache/cassandra/blob/trunk/test/unit/org/apache/cassandra/io/sstable/LegacySSTableTest.java#L96]}}
is not defined.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message