cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14118) Refactor write path
Date Wed, 11 Apr 2018 17:03:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434232#comment-16434232
] 

Aleksey Yeschenko commented on CASSANDRA-14118:
-----------------------------------------------

+1, this looks correct.

I was expecting a bigger patch, with more things abstracted - which is partially the reason
I procrastinated on this review - a little bit. FWIW, I think this changeset makes sense in
isolation, and I'm expecting that - eventually - the write path will be abstracted away more
fully. As of these commits, there are still default-engine specific things that live outside
the abstracted away path:
- there is an implicit assumption that secondary indexes are supported and work in a certain
way. In particular TableWriteHandler having UpdateTransaction as an argument
- MV related code living outside of either handler

With that in mind, again, I'm +1 with the patch, as a proto-abstraction with understanding
that it's only the beginning.

> Refactor write path
> -------------------
>
>                 Key: CASSANDRA-14118
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14118
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Dikang Gu
>            Assignee: Blake Eggleston
>            Priority: Major
>             Fix For: 4.0
>
>
> As part of the pluggable storage engine effort, we'd like to modularize the write path
related code, make it to be independent from existing storage engine implementation details.
> For now, refer to https://docs.google.com/document/d/1suZlvhzgB6NIyBNpM9nxoHxz_Ri7qAm-UEO8v8AIFsc
for high level designs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message