cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Tunnicliffe (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-14412) Restore automatic snapshot of system keyspace during upgrade
Date Mon, 23 Apr 2018 12:43:00 GMT


Sam Tunnicliffe commented on CASSANDRA-14412:

Pushed a branch [here|] which adds back the
call to {{SystemKeyspace::snapshotOnVersionChange}}, minus the call to {{SystemKeyspace::migrateDataDirs}}
that it was previously guarding, but which is genuinely no longer necessary. As snapshots
are reasonably cheap and an upgrade should be a rare event anyway, I've extended the original
method to also snapshot {{system_schema}}.

CI here: 

> Restore automatic snapshot of system keyspace during upgrade
> ------------------------------------------------------------
>                 Key: CASSANDRA-14412
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Lifecycle
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>            Priority: Major
>             Fix For: 4.0
> Since 2.2, the installed version is compared with the version persisted in system.local
(if any) at startup. If these versions differ, the system keyspace is snapshotted before proceeding
in order to enable a rollback if any other issue prevents startup from completing. Although
the method to perform this check & snapshot is still present in {{SystemKeyspace}}, its
only callsite was mistakenly removed from {{CassandraDaemon}} in CASSANDRA-12716.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message