cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Jirsa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14426) cassandra-stress throws NPE if insert section isn't specified in user profile
Date Sat, 28 Apr 2018 18:22:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457737#comment-16457737
] 

Jeff Jirsa commented on CASSANDRA-14426:
----------------------------------------

Appreciate the debugging and the fix. I think your fix is fine, but I'd like to change it
a bit to move the:

{code}
        if (insert == null)
            insert = new HashMap<>();
        lowerCase(insert);
{code}

>From below the {{if (!isKeyOnlyTable)}} if/else block to above, making your check irrelevant.
 Are you OK with that change? 

> cassandra-stress throws NPE if insert section isn't specified in user profile
> -----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-14426
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14426
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Stress
>            Reporter: Alex Ott
>            Assignee: Alex Ott
>            Priority: Trivial
>             Fix For: 4.x
>
>
> When user profile file is used, and insert section isn't specified, then cassandra-stress
is using default values instead.
> Since support for LWTs was added, absence of the insert section lead to throwing of NullPointerException
when generating inserts:
> {noformat}
> java.lang.NullPointerException
> 	at org.apache.cassandra.stress.StressProfile.getInsert(StressProfile.java:546)
> 	at org.apache.cassandra.stress.StressProfile.printSettings(StressProfile.java:126)
> 	at org.apache.cassandra.stress.settings.StressSettings.lambda$printSettings$1(StressSettings.java:311)
> 	at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
> 	at org.apache.cassandra.stress.settings.StressSettings.printSettings(StressSettings.java:311)
> 	at org.apache.cassandra.stress.Stress.run(Stress.java:108)
> 	at org.apache.cassandra.stress.Stress.main(Stress.java:63)
> {noformat}
> Fix is trivial, and will be provided as PR



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message