cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13698) Reinstate or get rid of unit tests with multiple compaction strategies
Date Thu, 07 Jun 2018 11:10:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504537#comment-16504537
] 

Paulo Motta commented on CASSANDRA-13698:
-----------------------------------------

Oops, my bad, indeed it seems I applied the 3.0 patch to 3.11 and forgot to verify the merge
- sorry about that. Fixed with 7bb88deb4c6387fd67114543986774c903860de9. Thanks for the heads
up!

> Reinstate or get rid of unit tests with multiple compaction strategies
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-13698
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13698
>             Project: Cassandra
>          Issue Type: Test
>          Components: Testing
>            Reporter: Paulo Motta
>            Assignee: Lerh Chuan Low
>            Priority: Minor
>              Labels: lhf
>             Fix For: 4.0, 3.0.17, 3.11.3
>
>         Attachments: 13698-3.0.txt, 13698-3.11.txt, 13698-hotfix.txt, 13698-trunk.txt
>
>
> At some point there were (anti-)compaction tests with multiple compaction strategy classes,
but now it's only tested with {{STCS}}:
> * [AnticompactionTest|https://github.com/apache/cassandra/blob/8b3a60b9a7dbefeecc06bace617279612ec7092d/test/unit/org/apache/cassandra/db/compaction/AntiCompactionTest.java#L247]
> * [CompactionsTest|https://github.com/apache/cassandra/blob/8b3a60b9a7dbefeecc06bace617279612ec7092d/test/unit/org/apache/cassandra/db/compaction/CompactionsTest.java#L85]
> We should either reinstate these tests or decide they are not important and remove the
unused parameter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message