cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14457) Add a virtual table with current compactions
Date Tue, 05 Jun 2018 13:41:01 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501794#comment-16501794
] 

Aleksey Yeschenko commented on CASSANDRA-14457:
-----------------------------------------------

Committed to trunk as [899f7c41935d92f15bc17a33f36443030616c8eb|https://github.com/apache/cassandra/commit/899f7c41935d92f15bc17a33f36443030616c8eb],
thanks.

Made some minor tweaks on commit:
- Use the correct {{Optional.ofNullable()}} rather than {{Optional.of()}} in {{getKeyspace()}}
and {{getTable()}}
- Fix {{asMap()}} to properly handle empty {{Optional}}s so it doesn't throw
- Made nodetool {{CompactionStats}} use {{CompactionInfo}} constants that we have now to access
the map
- Hid dealing with {{Holder}} in {{CompactionMetrics}}

In an unrelated note: why, why on Earth is {{CompactionMetrics}} the place that is the authorative
source of all running compactions? And all that stored in a static synchronised identity set?
Has nobody been bothered by this since 2012?

> Add a virtual table with current compactions
> --------------------------------------------
>
>                 Key: CASSANDRA-14457
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14457
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Chris Lohfink
>            Assignee: Chris Lohfink
>            Priority: Minor
>             Fix For: 4.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message