cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14488) Avoid unneeded memory allocations / cpu for disabled log levels
Date Sat, 02 Jun 2018 11:05:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499006#comment-16499006
] 

ASF GitHub Bot commented on CASSANDRA-14488:
--------------------------------------------

GitHub user benbenw opened a pull request:

    https://github.com/apache/cassandra/pull/231

    CASSANDRA-14488 Avoid unneeded memory allocations / cpu for disabled log levels

    add debug and trace log guard when the parameters creation implies memory allocations
and / or cpu.
    
    Especially for StreamingInboundHandler/NettyStreamingMessageSender where
    createLogTag is allocating 64*2+UUID#toString bytes

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benbenw/cassandra CASSANDRA-14488

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cassandra/pull/231.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #231
    
----
commit 0d8de4a2c0b58a42a7fb00c917d5c50286ee41d9
Author: benoit <b.wiart@...>
Date:   2018-06-02T09:55:28Z

    add debug and trace log guard when the parameters creation implies
    memory allocations and / or cpu.
    
    Especially for StreamingInboundHandler/NettyStreamingMessageSender where
    createLogTag is allocating 64*2+UUID#toString bytes

----


> Avoid unneeded memory allocations / cpu for disabled log levels
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-14488
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14488
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Benoit Wiart
>            Priority: Minor
>
> add debug and trace log guard when the parameters creation implies memory allocations
and / or cpu.
> Especially for StreamingInboundHandler/NettyStreamingMessageSender where createLogTag
is allocating 64*2+UUID#toString bytes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message