cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14524) Client metrics refactor
Date Wed, 20 Jun 2018 16:49:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518341#comment-16518341
] 

Aleksey Yeschenko commented on CASSANDRA-14524:
-----------------------------------------------

I feel like it was not really necessary to make {{Connection}} abstract, and {{View}} an interface.
It'd be sufficient to leave the former concrete, and make the latter a nested class of {{ServerConnection}},
and only add {{view()}} method to {{ServerConnection}}.

We don't really have any other real implementations, nor planning to.

> Client metrics refactor
> -----------------------
>
>                 Key: CASSANDRA-14524
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14524
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Chris Lohfink
>            Assignee: Chris Lohfink
>            Priority: Minor
>             Fix For: 4.0.x
>
>
> Moving refactoring out of CASSANDRA-14458 to be reviewed separately.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message