cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Lohfink (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14524) Client metrics refactor
Date Wed, 20 Jun 2018 17:18:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518361#comment-16518361
] 

Chris Lohfink commented on CASSANDRA-14524:
-------------------------------------------

Id still like view() to be in Connection as thats what we pass it around as. That way I don't
have to check type and cast considering ServerConnection is the only implementation. Having
it abstract was more for future proofing in case someone for whatever reason does create a
new connection type. How about making it concrete and Nullable or Optional and default returns
null?

> Client metrics refactor
> -----------------------
>
>                 Key: CASSANDRA-14524
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14524
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Chris Lohfink
>            Assignee: Chris Lohfink
>            Priority: Minor
>             Fix For: 4.0.x
>
>
> Moving refactoring out of CASSANDRA-14458 to be reviewed separately.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message