cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dinesh Joshi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14540) Internode messaging handshake sends wrong messaging version number
Date Mon, 25 Jun 2018 05:17:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521858#comment-16521858
] 

Dinesh Joshi commented on CASSANDRA-14540:
------------------------------------------

Thanks, [~jasobrown]Ā LGTM +1

> Internode messaging handshake sends wrong messaging version number
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-14540
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14540
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Streaming and Messaging
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>            Priority: Blocker
>             Fix For: 4.x
>
>
> With the refactor of internode messaging to netty in 4.0, we abstracted the protocol
handshakes messages into a class and handlers. There is a bug when the initiator of the connection
sends, in the third message of the handshake, it's own default protocol version number ({{MessagingService.current_version}}),
rather than the negotiated version. This was not causing any obvious problems when CASSANDRA-8457
was initially committed, but the bug is exposed after CASSANDRA-7544. The problem is during
rolling upgrades of 3.0/3.X to 4.0, nodes cannot correctly connect. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message