cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra
Date Fri, 13 Jul 2018 21:29:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543739#comment-16543739
] 

ASF GitHub Bot commented on CASSANDRA-14556:
--------------------------------------------

Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r202477311
  
    --- Diff: src/java/org/apache/cassandra/db/DiskBoundaries.java ---
    @@ -129,4 +129,19 @@ public int getBoundariesFromSSTableDirectory(Descriptor descriptor)
         {
             return directories.get(getDiskIndex(sstable));
         }
    +
    +    public Directories.DataDirectory getCorrectDiskForKey(DecoratedKey key)
    +    {
    +        if (positions == null)
    +            return null;
    +
    +        return directories.get(getDiskIndex(key));
    +    }
    +
    +    private int getDiskIndex(DecoratedKey key)
    +    {
    +        int pos = Collections.binarySearch(positions, key);
    --- End diff --
    
    This method is pretty much a replica of `getDiskIndex(SSTableReader sstable)` (See: https://github.com/dineshjoshi/cassandra/blob/657ce3670a5291decf2939d72d51abe19333ef15/src/java/org/apache/cassandra/db/DiskBoundaries.java#L102)
Instead of accepting a sstable, I pass in a `DecoratedKey`.
    
    We ensure that the range is owned at the upper levels of the stack.


> Optimize streaming path in Cassandra
> ------------------------------------
>
>                 Key: CASSANDRA-14556
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Streaming and Messaging
>            Reporter: Dinesh Joshi
>            Assignee: Dinesh Joshi
>            Priority: Major
>              Labels: Performance
>             Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates unnecessary
garbage and slows down the whole streaming process as some sstables can be transferred as
a whole file rather than individual partitions. The objective of the ticket is to detect when
a whole sstable can be transferred and skip the object reification. We can also use a zero-copy
path to avoid bringing data into user-space on both sending and receiving side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message