cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra
Date Fri, 13 Jul 2018 21:45:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543768#comment-16543768
] 

ASF GitHub Bot commented on CASSANDRA-14556:
--------------------------------------------

Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r202480493
  
    --- Diff: src/java/org/apache/cassandra/db/streaming/CassandraStreamHeader.java ---
    @@ -168,10 +232,35 @@ public void serialize(CassandraStreamHeader header, DataOutputPlus
out, int vers
                 header.calculateCompressionInfo();
                 CompressionInfo.serializer.serialize(header.compressionInfo, out, version);
                 out.writeInt(header.sstableLevel);
    +
                 SerializationHeader.serializer.serialize(header.version, header.header, out);
    +
    +            header.tableId.serialize(out);
    +            out.writeBoolean(header.fullStream);
    +
    +            if (header.fullStream)
    +            {
    +                out.writeInt(header.components.size());
    +                for (ComponentInfo info : header.components)
    +                    ComponentInfo.serializer.serialize(info, out, version);
    +
    +                ByteBufferUtil.writeWithShortLength(header.firstKey.getKey(), out);
    --- End diff --
    
    OK, actually Jeff pointed out that we do have partitioners where decorated keys are not
hashes. So either we find out what the max length is or just use an int/varint and call it
good. We don't send this often so it's fine.


> Optimize streaming path in Cassandra
> ------------------------------------
>
>                 Key: CASSANDRA-14556
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Streaming and Messaging
>            Reporter: Dinesh Joshi
>            Assignee: Dinesh Joshi
>            Priority: Major
>              Labels: Performance
>             Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates unnecessary
garbage and slows down the whole streaming process as some sstables can be transferred as
a whole file rather than individual partitions. The objective of the ticket is to detect when
a whole sstable can be transferred and skip the object reification. We can also use a zero-copy
path to avoid bringing data into user-space on both sending and receiving side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message