cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra
Date Mon, 23 Jul 2018 16:03:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553033#comment-16553033
] 

ASF GitHub Bot commented on CASSANDRA-14556:
--------------------------------------------

Github user iamaleksey commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r204458523
  
    --- Diff: src/java/org/apache/cassandra/config/DatabaseDescriptor.java ---
    @@ -2260,6 +2260,20 @@ public static int getStreamingConnectionsPerHost()
             return conf.streaming_connections_per_host;
         }
     
    +    public static boolean isFullSSTableTransfersEnabled()
    +    {
    +        if (conf.server_encryption_options.enabled || conf.server_encryption_options.optional)
    +        {
    +            logger.debug("Internode encryption enabled. Disabling zero copy SSTable transfers
for streaming.");
    --- End diff --
    
    Nobody will ever see this at `debug` level. We should at minimum `warn` if `streaming_zerocopy_sstables_enabled`
is and internode encryption are both enabled at the same time.


> Optimize streaming path in Cassandra
> ------------------------------------
>
>                 Key: CASSANDRA-14556
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Streaming and Messaging
>            Reporter: Dinesh Joshi
>            Assignee: Dinesh Joshi
>            Priority: Major
>              Labels: Performance
>             Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates unnecessary
garbage and slows down the whole streaming process as some sstables can be transferred as
a whole file rather than individual partitions. The objective of the ticket is to detect when
a whole sstable can be transferred and skip the object reification. We can also use a zero-copy
path to avoid bringing data into user-space on both sending and receiving side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message