cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra
Date Wed, 25 Jul 2018 00:57:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554975#comment-16554975
] 

ASF GitHub Bot commented on CASSANDRA-14556:
--------------------------------------------

Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/239#discussion_r204955043
  
    --- Diff: src/java/org/apache/cassandra/db/lifecycle/LogFile.java ---
    @@ -66,7 +66,7 @@
         private final LogReplicaSet replicas = new LogReplicaSet();
     
         // The transaction records, this set must be ORDER PRESERVING
    -    private final LinkedHashSet<LogRecord> records = new LinkedHashSet<>();
    +    private final Set<LogRecord> records = Collections.synchronizedSet(new LinkedHashSet<>());
// TODO: Hack until we fix CASSANDRA-14554
    --- End diff --
    
    I should've worded the comment differently but it is a hack to avoid a `ConcurrentModificationException`
([CASSANDRA-14554](https://issues.apache.org/jira/browse/CASSANDRA-14554)). This currently
exists in trunk and was not introduced as part of this PR hence the separate ticket.


> Optimize streaming path in Cassandra
> ------------------------------------
>
>                 Key: CASSANDRA-14556
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14556
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Streaming and Messaging
>            Reporter: Dinesh Joshi
>            Assignee: Dinesh Joshi
>            Priority: Major
>              Labels: Performance
>             Fix For: 4.x
>
>
> During streaming, Cassandra reifies the sstables into objects. This creates unnecessary
garbage and slows down the whole streaming process as some sstables can be transferred as
a whole file rather than individual partitions. The objective of the ticket is to detect when
a whole sstable can be transferred and skip the object reification. We can also use a zero-copy
path to avoid bringing data into user-space on both sending and receiving side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message