cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-14556) Optimize streaming path in Cassandra
Date Wed, 25 Jul 2018 13:49:02 GMT


ASF GitHub Bot commented on CASSANDRA-14556:

Github user iamaleksey commented on a diff in the pull request:
    --- Diff: src/java/org/apache/cassandra/db/compaction/ ---
    @@ -361,12 +361,26 @@ public RangeOwnHelper(List<Range<Token>> normalizedRanges)
              * @throws RuntimeException if the key is not contained
             public void check(DecoratedKey key)
    +        {
    +            if (!checkBoolean(key))
    --- End diff --
    Yep, this is exactly what I had in mind, thanks. Not sure of the names, though. Would
prefer the throwing `check()` to be renamed into `validate()`, and `checkBoolean()` to become
`check()`. `validate()` is the name we often give to such methods (that throw on failure).

> Optimize streaming path in Cassandra
> ------------------------------------
>                 Key: CASSANDRA-14556
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Streaming and Messaging
>            Reporter: Dinesh Joshi
>            Assignee: Dinesh Joshi
>            Priority: Major
>              Labels: Performance
>             Fix For: 4.x
> During streaming, Cassandra reifies the sstables into objects. This creates unnecessary
garbage and slows down the whole streaming process as some sstables can be transferred as
a whole file rather than individual partitions. The objective of the ticket is to detect when
a whole sstable can be transferred and skip the object reification. We can also use a zero-copy
path to avoid bringing data into user-space on both sending and receiving side.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message