cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14896) 3.0 schema migration pulls from later version incompatible nodes
Date Wed, 28 Nov 2018 22:57:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702486#comment-16702486
] 

Jason Brown commented on CASSANDRA-14896:
-----------------------------------------

[~aweisberg] is correct. On the third (and last) message of the internode messaging handshake,
the node is [incorrectly sending back|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/async/OutboundHandshakeHandler.java#L180]
the messaging version is received from the peer; it should be sending back it's own {{MessagingService.current_version}}.

Here's a one-line fix for sending the correct messaging version in {{ThirdHandshakeMessage}}
as well as fixing the unit test that ensures the version being sent from {{OutboundHandshakeHandler}}
||14896||
|[branch|https://github.com/jasobrown/cassandra/tree/14896]|
|[utests & dtests|https://circleci.com/gh/jasobrown/workflows/cassandra/tree/14896]|

> 3.0 schema migration pulls from later version incompatible nodes
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-14896
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14896
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core, CQL
>            Reporter: Ariel Weisberg
>            Assignee: Ariel Weisberg
>            Priority: Blocker
>              Labels: 4.0-pre-rc-bugs
>             Fix For: 3.0.x
>
>
> I saw this in upgrade tests. The checks in 3.0 and 3.11 are slightly different and 3.0
in some scenarios it is pulling schema from a later version. This causes upgrade tests to
have errors in the logs due to additional columns from configurable storage port.
> {noformat}
> Failed: Error details: 
> Errors seen in logs for: node2
> node2: ERROR [MessagingService-Incoming-/127.0.0.1] 2018-11-15 21:17:46,739 CassandraDaemon.java:207
- Exception in thread Thread[MessagingService-Incoming-/127.0.0.1,5,main]
> java.lang.RuntimeException: Unknown column additional_write_policy during deserialization
> 	at org.apache.cassandra.db.Columns$Serializer.deserialize(Columns.java:433) ~[apache-cassandra-3.0.17.jar:3.0.17]
> 	at org.apache.cassandra.db.SerializationHeader$Serializer.deserializeForMessaging(SerializationHeader.java:440)
~[apache-cassandra-3.0.17.jar:3.0.17]
> 	at org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.deserializeHeader(UnfilteredRowIteratorSerializer.java:190)
~[apache-cassandra-3.0.17.jar:3.0.17]
> 	at org.apache.cassandra.db.partitions.PartitionUpdate$PartitionUpdateSerializer.deserialize30(PartitionUpdate.java:686)
~[apache-cassandra-3.0.17.jar:3.0.17]
> 	at org.apache.cassandra.db.partitions.PartitionUpdate$PartitionUpdateSerializer.deserialize(PartitionUpdate.java:674)
~[apache-cassandra-3.0.17.jar:3.0.17]
> 	at org.apache.cassandra.db.Mutation$MutationSerializer.deserialize(Mutation.java:337)
~[apache-cassandra-3.0.17.jar:3.0.17]
> 	at org.apache.cassandra.db.Mutation$MutationSerializer.deserialize(Mutation.java:346)
~[apache-cassandra-3.0.17.jar:3.0.17]
> 	at org.apache.cassandra.service.MigrationManager$MigrationsSerializer.deserialize(MigrationManager.java:641)
~[apache-cassandra-3.0.17.jar:3.0.17]
> 	at org.apache.cassandra.service.MigrationManager$MigrationsSerializer.deserialize(MigrationManager.java:624)
~[apache-cassandra-3.0.17.jar:3.0.17]
> 	at org.apache.cassandra.net.MessageIn.read(MessageIn.java:98) ~[apache-cassandra-3.0.17.jar:3.0.17]
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessage(IncomingTcpConnection.java:201)
~[apache-cassandra-3.0.17.jar:3.0.17]
> 	at org.apache.cassandra.net.IncomingTcpConnection.receiveMessages(IncomingTcpConnection.java:178)
~[apache-cassandra-3.0.17.jar:3.0.17]
> 	at org.apache.cassandra.net.IncomingTcpConnection.run(IncomingTcpConnection.java:92)
~[apache-cassandra-3.0.17.jar:3.0.17]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message