cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (Jira)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14781) Log message when mutation passed to CommitLog#add(Mutation) is too large is not descriptive enough
Date Tue, 12 Nov 2019 16:31:01 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972590#comment-16972590
] 

Aleksey Yeschenko commented on CASSANDRA-14781:
-----------------------------------------------

I'd say this is a little insufficient. You have the exact same situation with writing hints
in {{HintsBuffer.allocate()}}.

What you want is to add an extra validation downstream all the way to {{ModificationStatement}},
so that you can return a meaningful exception to the client immediately - rather than ending
up timing out the response.

> Log message when mutation passed to CommitLog#add(Mutation) is too large is not descriptive
enough
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-14781
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14781
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Local Write-Read Paths
>            Reporter: Jordan West
>            Assignee: Tom Petracca
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.x
>
>         Attachments: CASSANDRA-14781.patch, CASSANDRA-14781_3.0.patch, CASSANDRA-14781_3.11.patch
>
>
> When hitting [https://github.com/apache/cassandra/blob/cassandra-3.0/src/java/org/apache/cassandra/db/commitlog/CommitLog.java#L256-L257],
the log message produced does not help the operator track down what data is being written.
At a minimum the keyspace and cfIds involved would be useful (and are available) – more
detail might not be reasonable to include. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message