cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Deparvu (Jira)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-14888) Several mbeans are not unregistered when dropping a keyspace and table
Date Tue, 26 Nov 2019 16:53:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-14888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982668#comment-16982668
] 

Alex Deparvu commented on CASSANDRA-14888:
------------------------------------------

[~cnlwsu] I took another look and while the "wall of removes" is very fragile, it seems to
be the way to go, or at least I couldn't find a cleaner example in Cassandra of how to approach
this. One idea that I had was to have the factory keep track of registered & perform release
when needed (looking at KeyspaceMetrics: basically move allMetrics into KeyspaceMetricNameFactory
and add a #release method for cleanup).
Again, I would love a pointer to prior art here, so I get a better understanding of expectations.

Also, regarding the tests, could you expand a bit on what is missing? I could improve this
bit so it covers MVs, not sure about the flakey scenarios.

> Several mbeans are not unregistered when dropping a keyspace and table
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-14888
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14888
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Observability/Metrics
>            Reporter: Ariel Weisberg
>            Assignee: Alex Deparvu
>            Priority: Urgent
>              Labels: patch-available
>             Fix For: 4.0, 4.0-rc
>
>         Attachments: CASSANDRA-14888.patch
>
>
> CasCommit, CasPrepare, CasPropose, ReadRepairRequests, ShortReadProtectionRequests, AntiCompactionTime,
BytesValidated, PartitionsValidated, RepairPrepareTime, RepairSyncTime, RepairedDataInconsistencies,
ViewLockAcquireTime, ViewReadTime, WriteFailedIdealCL
> Basically for 3 years people haven't known what they are doing because the entire thing
is kind of obscure. Fix it and also add a dtest that detects if any mbeans are left behind
after dropping a table and keyspace.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message