cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (Jira)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-15408) Cassandra throws SyntaxException for obsolete keywords that Thrift API permits
Date Mon, 11 Nov 2019 14:18:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-15408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971577#comment-16971577
] 

Aleksey Yeschenko commented on CASSANDRA-15408:
-----------------------------------------------

They have no effect anymore since 2.1, and were deprecated there. And, per our policies, removed
in the next major release after deprecation.

Not to mention Thrift is completely gone in 4.0 now. I would prefer to let these go personally.

> Cassandra throws SyntaxException for obsolete keywords that Thrift API permits
> ------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-15408
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15408
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Leon Zaruvinsky
>            Priority: Normal
>         Attachments: CASSANDRA-15408.patch
>
>
> In [this refactor|https://github.com/apache/cassandra/commit/b31845c4a7982358a7c5bfd9bcf572fda6c1bfa9#diff-826a67bf1ae2e45372a35a6a2a6f3f3cL74]
of CFPropDefs to TableAttributes for CASSANDRA-9712, three obsolete keywords were removed:
> {code:java}
>         obsoleteKeywords.add("index_interval");
>         obsoleteKeywords.add("replicate_on_write");
>         obsoleteKeywords.add("populate_io_cache_on_flush");
> {code}
>  
> The Thrift API continues to reference these keywords as deprecated, so it's not clear
that they are actually unsupported.
> Could we either add them back as obsoleteKeywords, or add a change log that statements
with these properties will fail (There is already a changelog about "index_interval" but not
the other two)?  I understand that the Thrift API is totally deprecated so I don't feel strongly
about cleaning it up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message