cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksandr Sorokoumov (Jira)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-13917) COMPACT STORAGE queries on dense static tables accept hidden column1 and value columns
Date Thu, 16 Jan 2020 09:45:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016761#comment-17016761
] 

Aleksandr Sorokoumov commented on CASSANDRA-13917:
--------------------------------------------------

I did run unit tests after all changes; should have run upgrade tests as well.

Here are the fixup patches that use the hidden column logic only for statements:

Branches:
* [13917-fixup-3.0|https://github.com/apache/cassandra/compare/cassandra-3.0...Gerrrr:13917-fixup-3.0]
* [13917-fixup-3.11|https://github.com/apache/cassandra/compare/cassandra-3.11...Gerrrr:13917-fixup-3.11]

CI results:
* [13917-fixup-3.0-testall|https://issues.apache.org/jira/secure/attachment/12991097/13917-3.0-testall-16.01.2020]
* [13917-fixup-3.0-upgrade|https://issues.apache.org/jira/secure/attachment/12991098/13917-3.0-upgrade-16.01.2020]
* [13917-fixup-3.11-testall|https://issues.apache.org/jira/secure/attachment/12991099/13917-3.11-testall-16.01.2020.png]
* [13917-fixup-3.11-upgrade|https://issues.apache.org/jira/secure/attachment/12991100/13917-3.11-upgrade-16.01.2020.png]

> COMPACT STORAGE queries on dense static tables accept hidden column1 and value columns
> --------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-13917
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13917
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Core
>            Reporter: Alex Petrov
>            Assignee: Aleksandr Sorokoumov
>            Priority: Low
>              Labels: lhf
>             Fix For: 3.0.x, 3.11.x
>
>         Attachments: 13917-3.0-testall-13.12.2019, 13917-3.0-testall-16.01.2020, 13917-3.0-testall-2.png,
13917-3.0-testall-20.11.2019.png, 13917-3.0-upgrade-16.01.2020, 13917-3.0.png, 13917-3.11-testall-13.12.2019,
13917-3.11-testall-16.01.2020.png, 13917-3.11-testall-2.png, 13917-3.11-testall-20.11.2019.png,
13917-3.11-upgrade-16.01.2020.png, 13917-3.11.png
>
>
> Test for the issue:
> {code}
>     @Test
>     public void testCompactStorage() throws Throwable
>     {
>         createTable("CREATE TABLE %s (a int PRIMARY KEY, b int, c int) WITH COMPACT STORAGE");
>         assertInvalid("INSERT INTO %s (a, b, c, column1) VALUES (?, ?, ?, ?)", 1, 1,
1, ByteBufferUtil.bytes('a'));
>         // This one fails with Some clustering keys are missing: column1, which is still
wrong
>         assertInvalid("INSERT INTO %s (a, b, c, value) VALUES (?, ?, ?, ?)", 1, 1, 1,
ByteBufferUtil.bytes('a'));       
>         assertInvalid("INSERT INTO %s (a, b, c, column1, value) VALUES (?, ?, ?, ?, ?)",
1, 1, 1, ByteBufferUtil.bytes('a'), ByteBufferUtil.bytes('b'));
>         assertEmpty(execute("SELECT * FROM %s"));
>     }
> {code}
> Gladly, these writes are no-op, even though they succeed.
> {{value}} and {{column1}} should be completely hidden. Fixing this one should be as easy
as just adding validations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message