cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Capwell (Jira)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-15499) Internode message builder does not add trace header
Date Thu, 16 Jan 2020 15:58:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017058#comment-17017058
] 

David Capwell commented on CASSANDRA-15499:
-------------------------------------------

Thanks for the details

> Internode message builder does not add trace header
> ---------------------------------------------------
>
>                 Key: CASSANDRA-15499
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15499
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Messaging/Internode
>            Reporter: Yifan Cai
>            Assignee: Yifan Cai
>            Priority: Normal
>              Labels: pull-request-available
>             Fix For: 4.x
>
>
> The messages built with the {{Builder}} ({{org.apache.cassandra.net.Message.Builder}})
do not have the trace header when tracing is enabled. 
> Consequently, no tracing session gets propagated to other nodes, and the tracing function
is broken. 
> The set of static {{out*}} methods provided (to create an out-bounding message) in Message
do not have the issue. They can properly add the trace header when necessary. 
> To be clear, only the {{Builder}} missed adding the tracing header and it should be fixed
to be consistent with the {{out*}} methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message