cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yifan Cai (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-15499) Internode message builder does not add trace header
Date Thu, 16 Jan 2020 16:08:00 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-15499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17017069#comment-17017069
] 

Yifan Cai edited comment on CASSANDRA-15499 at 1/16/20 4:07 PM:
----------------------------------------------------------------

Hi [~aleksey]

The {{Message#out*}} methods are good and it was stated in the ticket description. However,
those 2 message creation approaches are inconsistent. So this patch aims to close the gap.


What is the desired usage of using the {{Message.Builder}}? I feel having 2 implementations
of message creation can have problem in maintaining the code. To me, using {{Message.Builder}}
gives more flexibility. 

bq. It would help if you showed the code from your other upcoming patch.
Attaching the link to the [patch|https://github.com/apache/cassandra/compare/trunk...yifan-c:CASSANDRA-2848-per-request-timeout]
to see it helps to give more context. *Discussion about the attached patch does not fit the
topic of this ticket.* The patch involves a lot of changes. Please search for "Message.Builder"
to see the usage of it. In short, builder is used to adjust the message expiration time since
the query is allowed accept custom timeout value. 



was (Author: yifanc):
The {{Message#out*}} methods are good and it was stated in the ticket description. However,
those 2 message creation approaches are inconsistent. So this patch aims to close the gap.


What is the desired usage of using the {{Message.Builder}}? I feel having 2 implementations
of message creation can have problem in maintaining the code. To me, using {{Message.Builder}}
gives more flexibility. 

bq. It would help if you showed the code from your other upcoming patch.
Attaching the link to the [patch|https://github.com/apache/cassandra/compare/trunk...yifan-c:CASSANDRA-2848-per-request-timeout]
to see it helps to give more context. *Discussion about the attached patch does not fit the
topic of this ticket.* The patch involves a lot of changes. Please search for "Message.Builder"
to see the usage of it. In short, builder is used to adjust the message expiration time since
the query is allowed accept custom timeout value. 


> Internode message builder does not add trace header
> ---------------------------------------------------
>
>                 Key: CASSANDRA-15499
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15499
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Messaging/Internode
>            Reporter: Yifan Cai
>            Assignee: Yifan Cai
>            Priority: Normal
>              Labels: pull-request-available
>             Fix For: 4.x
>
>
> The messages built with the {{Builder}} ({{org.apache.cassandra.net.Message.Builder}})
do not have the trace header when tracing is enabled. 
> Consequently, no tracing session gets propagated to other nodes, and the tracing function
is broken. 
> The set of static {{out*}} methods provided (to create an out-bounding message) in Message
do not have the issue. They can properly add the trace header when necessary. 
> To be clear, only the {{Builder}} missed adding the tracing header and it should be fixed
to be consistent with the {{out*}} methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org


Mime
View raw message